[KCMs] Use consistent text for GHNS buttons
ClosedPublic

Authored by ngraham on Oct 29 2018, 3:42 AM.

Details

Summary

Implement consistent text format as decided on in T9941. Also change docbooks, as appropriate.
Closes T9941

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
consistent-ghns-button-wording (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4298
Build 4316: arc lint + arc unit
ngraham created this revision.Oct 29 2018, 3:42 AM
Restricted Application added projects: Plasma, Documentation. · View Herald TranscriptOct 29 2018, 3:42 AM
Restricted Application added subscribers: kde-doc-english, plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 29 2018, 3:42 AM
ngraham edited the test plan for this revision. (Show Details)Oct 29 2018, 3:46 AM

I don't feel 100% about the desktop theme and L&F labels since they both use the word "themes". I feel like maybe we can do better than that but was running out of creativity. Maybe Get New Look and Feel Packages? Get New Looks And Feels? Ugh, that's awful.

abetts added a subscriber: abetts.Oct 29 2018, 4:37 AM

I like the direction of the patch.

My only thing is that we drop the use of the word "Scheme". I think we could use something different like "Pattern", "Swatch", "Theme", etc. If it is about colors, I think swatch would be really cool.

Aniyher thing here that We need to make all get new stuff buttons in the same position in each category
Bcs its now somehow confusing
Top right
Bottom left
Etc

Aniyher thing here that We need to make all get new stuff buttons in the same position in each category
Bcs its now somehow confusing
Top right
Bottom left
Etc

Yes, I also noticed that while working on this. I plan to address it in another patch once the labels are all changed.

I like the direction of the patch.

My only thing is that we drop the use of the word "Scheme". I think we could use something different like "Pattern", "Swatch", "Theme", etc. If it is about colors, I think swatch would be really cool.

Yeah, the word "scheme" is kind of negative in English. Unfortunately, the term "Color Scheme" is used everywhere, so I think changing that will require more discussion and should be done in another patch.

I like the direction of the patch.

My only thing is that we drop the use of the word "Scheme". I think we could use something different like "Pattern", "Swatch", "Theme", etc. If it is about colors, I think swatch would be really cool.

Yeah, the word "scheme" is kind of negative in English. Unfortunately, the term "Color Scheme" is used everywhere, so I think changing that will require more discussion and should be done in another patch.

I'd be up for that.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 30 2018, 1:11 PM
This revision was automatically updated to reflect the committed changes.