Use better, less technical, and more consistent strings for name, comment, and GHNS button
ClosedPublic

Authored by ngraham on Oct 29 2018, 3:42 AM.

Details

Summary

Change the KCM's name and comment to match one another and be less technical.

Also Implement consistent text format as decided on in T9941.

Test Plan

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Branch
consistent-ghns-button-wording (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4296
Build 4314: arc lint + arc unit
ngraham created this revision.Oct 29 2018, 3:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 29 2018, 3:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 29 2018, 3:42 AM
ngraham edited the test plan for this revision. (Show Details)

Open to suggestions on wording here. Would "Styles" be better than "Themes? "Styles" is used in the title after all...

ngraham updated this revision to Diff 44403.Oct 29 2018, 4:06 AM

Themes -> Styles; it's more consistent with the wording used elsewhere in the KCM

ngraham edited the test plan for this revision. (Show Details)Oct 29 2018, 4:07 AM
apol added a subscriber: apol.Oct 29 2018, 1:47 PM

Are you sure it makes sense to mention gnome? The user who uses this will more likely use it to modify behavior of random GTK apps.

GNOME is already (inconsistently) mentioned twice in the KCM's name and title:

I was just following the pattern, but I'd be happy to change the name title too if appropriate.

apol added a comment.Oct 29 2018, 2:57 PM

If you could give consistency to it, that would be awesome. Do what you think is best and I'll approve :).

ngraham updated this revision to Diff 44449.Oct 29 2018, 4:22 PM

Also update the name and comment to better match and be less technical

ngraham retitled this revision from Use consistent text for the GHNS button to Use better, less technical, and more consistent strings for name, comment, and GHNS button.Oct 29 2018, 4:23 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
apol accepted this revision.Oct 29 2018, 5:16 PM
This revision is now accepted and ready to land.Oct 29 2018, 5:16 PM
This revision was automatically updated to reflect the committed changes.