Differential D16497

Give the GHNS button an appropriate icon and more consistent text
ClosedPublic
Actions

Authored by ngraham on Oct 28 2018, 9:37 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Maniphest Tasks
T9941: Make Get Hot New Stuff button wording consistent
Commits
R123:de088bdca917: Give the GHNS button an appropriate icon and more consistent text
Summary

This patch gives the GHNS button an icon and tweaks its text to be consistent with the general pattern seen in other KCMs.
BUG: 400424
FIXED-IN: 5.15.0

Test Plan

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Branch
ghns-icon-on-button (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4288
Build 4306: arc lint + arc unit
ngraham created this revision.Oct 28 2018, 9:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 28 2018, 9:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 28 2018, 9:37 PM
ngraham edited the test plan for this revision. (Show Details)Oct 28 2018, 9:38 PM
ngraham added reviewers: Plasma, VDG.
davidedmundson accepted this revision.Oct 28 2018, 10:16 PM
davidedmundson added a subscriber: davidedmundson.

Worth tagging other one-liner commits like this as junior-jobs for GCI.

This revision is now accepted and ready to land.Oct 28 2018, 10:16 PM
ngraham added a comment.Oct 28 2018, 10:49 PM
In D16497#350082, @davidedmundson wrote:

Worth tagging other one-liner commits like this as junior-jobs for GCI.

Good idea. Just use the standard junior-job keyword, or is there a specific one just for GCI?

Closed by commit R123:de088bdca917: Give the GHNS button an appropriate icon and more consistent text (authored by ngraham). · Explain WhyOct 28 2018, 10:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ui/themeconfig.ui (5 lines)

Diff 44387

View Options

src/ui/themeconfig.ui

Loading...