Add button to dynamically resize virtual keyboard

Authored by graesslin on Oct 28 2018, 5:20 PM.



One of the things I dislike most about our virtual keyboard integration
is it's size. It's at least on my system covering too much vertical
space. Unfortuantely the keyboard API does not offer a way to control
the vertical space - one can only control the width. Thus it's also not
possible to just provide the keyboard in the optimal size.

This change tries to address the problem by adding a resize button. When
pressed one can dynamically decrease and increase the width of the
keyboard and thus also the height.

The button is added to the top/right corner. Ideally it would be added
to the symbol button row, but either I couldn't find the appropriate API
hooks or it's not possible.

Test Plan

Started KWin with the change and tested with touch input

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Oct 28 2018, 5:20 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 28 2018, 5:20 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Oct 28 2018, 5:20 PM
romangg accepted this revision.EditedOct 29 2018, 9:27 AM
romangg added a subscriber: romangg.

Looks interesting. Let's live test this change.

Long term we should rethink the handling of the virtual keyboard in general. Biggest use problem for me at the moment is that it does not get invoked at the best moments and that it covers content without scrutiny, at worst the text the user is currently typing in. See also: T9815

This revision is now accepted and ready to land.Oct 29 2018, 9:27 AM
This revision was automatically updated to reflect the committed changes.