Differential D16483

[workspace KCM] Port to QQC2
ClosedPublic
Actions

Authored by ngraham on Oct 28 2018, 3:10 PM.

Details

Reviewers
davidedmundson
apol
Group Reviewers
Plasma
Commits
R119:a2c87ce86c80: [workspace KCM] Port to QQC2
Summary

Port the Workspace KCM to QQC2.

BUG: 385547
FIXED-IN: 5.15.0

Test Plan
  • All functionality still works
  • Keyboard navigation via the Tab key still works as expected
  • Looks good at with a fractional scale factor now; here shown at 1.5x:

Diff Detail

Repository
R119 Plasma Desktop
Branch
workspace-kcm-qqc2 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4270
Build 4288: arc lint + arc unit
ngraham created this revision.Oct 28 2018, 3:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 28 2018, 3:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 28 2018, 3:10 PM
ngraham edited the test plan for this revision. (Show Details)Oct 28 2018, 3:11 PM
ngraham updated this revision to Diff 44357.Oct 28 2018, 3:14 PM

Also use Kirigami.Separator correctly to get rid of the tiny dot between sections

ngraham edited the test plan for this revision. (Show Details)Oct 28 2018, 3:16 PM
apol accepted this revision.Oct 29 2018, 12:38 AM
This revision is now accepted and ready to land.Oct 29 2018, 12:38 AM
Closed by commit R119:a2c87ce86c80: [workspace KCM] Port to QQC2 (authored by ngraham). · Explain WhyOct 29 2018, 3:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44357

View Options

kcms/workspaceoptions/package/contents/ui/main.qml

Loading...