This is not a hugely important change. I noticed it while I was working on something else, and it seems like it ought to be this way
Details
Details
- Reviewers
albertvaka - Group Reviewers
KDE Connect - Commits
- R224:08b31ce2587d: Properly Assign LanLinkProvider as the Parent of its child objects
Nothing should be noticeably different
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4249 Build 4267: arc lint + arc unit
Comment Actions
It doesn't make a difference. Parent is useful when it will need deletion, but here it will happen with the object anyway.
Comment Actions
Having the parents set might be useful when using tools like gammaray.
I had to google up if this was safe, though, as it wasn't obvious to me that the deletion order wouldn't give problems :P
Comment Actions
It's also useful for moving the parent object to a different thread 😬
I had to google up if this was safe, though, as it wasn't obvious to me that the deletion order wouldn't give problems :P
Thanks for checking. It's good to have more experienced eyes looking for those little things I don't even know to think of!