Properly Assign LanLinkProvider as the Parent of its child objects
ClosedPublic

Authored by sredman on Oct 27 2018, 8:33 PM.

Details

Summary

This is not a hugely important change. I noticed it while I was working on something else, and it seems like it ought to be this way

Test Plan

Nothing should be noticeably different

Diff Detail

Repository
R224 KDE Connect
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4249
Build 4267: arc lint + arc unit
sredman created this revision.Oct 27 2018, 8:33 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 27 2018, 8:33 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Oct 27 2018, 8:33 PM
apol added a subscriber: apol.Oct 28 2018, 1:04 AM

It doesn't make a difference. Parent is useful when it will need deletion, but here it will happen with the object anyway.

albertvaka accepted this revision.Oct 29 2018, 2:10 PM
This revision is now accepted and ready to land.Oct 29 2018, 2:10 PM
albertvaka added a comment.EditedOct 29 2018, 2:12 PM

Having the parents set might be useful when using tools like gammaray.

I had to google up if this was safe, though, as it wasn't obvious to me that the deletion order wouldn't give problems :P

Having the parents set might be useful when using tools like gammaray.

It's also useful for moving the parent object to a different thread 😬

I had to google up if this was safe, though, as it wasn't obvious to me that the deletion order wouldn't give problems :P

Thanks for checking. It's good to have more experienced eyes looking for those little things I don't even know to think of!

sredman closed this revision.Oct 29 2018, 3:48 PM