Differential D16463

QtMath now provides M_PI constant, operations with degrees, and c++ provides round()
ClosedPublic
Actions

Authored by Shroudmaster on Oct 27 2018, 4:59 PM.

Details

Reviewers
tcanabrava
rizzitello
Commits
R337:1ac7883f5b05: QtMath now provides M_PI constant, operations with degrees, and c++ provides…
Summary

Since QtMath library has a proper M_PI the define is not necessary anymore. Furthermore, C++'s round() function behaves in similar fashion to the ROUND2INT macro (rounding away
from zero). If this style of rounding is not specifically required, I suggest another revision to change it to rint(), which rounds towards even numbers.

Diff Detail

Repository
R337 KTurtle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Shroudmaster created this revision.Oct 27 2018, 4:59 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 27 2018, 4:59 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Shroudmaster requested review of this revision.Oct 27 2018, 4:59 PM
rizzitello added a comment.Oct 29 2018, 9:53 AM

Since this is new code I think you should use the new style casts for these new casts.

tcanabrava requested changes to this revision.Nov 2 2018, 4:28 PM
tcanabrava added inline comments.
src/directiondialog.cpp
375

this style of casting will give us a lot of warnings when compilling with clang.
create a function that does a static_cast<int>(double) and return the int to get rid of the warnings.

This revision now requires changes to proceed.Nov 2 2018, 4:28 PM
rizzitello added inline comments.Nov 2 2018, 4:51 PM
src/directiondialog.cpp
375

Simply using the new cast style will remove the warning(s).
for example:

double x ; 
int z = (int)x; // old style cast warning 
int y = int(x); // no cast warning
Shroudmaster updated this revision to Diff 44945.Nov 6 2018, 12:36 AM

ok, fixed up the castings

rizzitello accepted this revision.Nov 6 2018, 1:57 AM
tcanabrava accepted this revision.Nov 6 2018, 9:24 AM
This revision is now accepted and ready to land.Nov 6 2018, 9:24 AM
Closed by commit R337:1ac7883f5b05: QtMath now provides M_PI constant, operations with degrees, and c++ provides… (authored by Shroudmaster, committed by rizzitello). · Explain WhyNov 13 2018, 9:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/canvas.cpp (18 lines)
Msrc/directiondialog.cpp (10 lines)
Msrc/interpreter/executer.cpp (29 lines)

Diff 45435

View Options

src/canvas.cpp

Loading...
View Options

src/directiondialog.cpp

Loading...
View Options

src/interpreter/executer.cpp

Loading...