Differential D16456

[effects/thumbnailaside] Save shortcuts
ClosedPublic
Actions

Authored by zzag on Oct 27 2018, 10:05 AM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:00c9b4c1c931: [effects/thumbnailaside] Save shortcuts
Summary

If user selects a shortcut to trigger the effect, that shortcut won't
work after the KCM is closed because we don't save it.

BUG: 400351
FIXED-IN: 5.14.3

Test Plan
  • Specified custom shortcut to trigger the effect;
  • Closed the KCM;
  • Pressed the shortcut, a thumbnail appeared.

Diff Detail

Repository
R108 KWin
Branch
effects-thumbnailaside-save-shortcuts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4232
Build 4250: arc lint + arc unit
zzag created this revision.Oct 27 2018, 10:05 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 27 2018, 10:05 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 27 2018, 10:05 AM
graesslin accepted this revision.Oct 27 2018, 4:03 PM
This revision is now accepted and ready to land.Oct 27 2018, 4:03 PM
Closed by commit R108:00c9b4c1c931: [effects/thumbnailaside] Save shortcuts (authored by zzag). · Explain WhyOct 27 2018, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44297

View Options

effects/thumbnailaside/thumbnailaside_config.cpp

Loading...