[KIconLoader] Adjust emblem border depending on icon size
ClosedPublic
Actions

Authored by bruns on Oct 26 2018, 8:04 PM.

Details

Reviewers

Group Reviewers

Frameworks
VDG

Commits

Summary

The current fixed margin of 2px on each side leads to overlapping
emblems and occlusion of large areas of the main icon.

Test Plan

Before:
After:

Repository

R302 KIconThemes

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Oct 26 2018, 8:04 PM

bruns edited the test plan for this revision. (Show Details)Oct 26 2018, 8:07 PM

bruns edited the test plan for this revision. (Show Details)Oct 26 2018, 8:13 PM

Ah, so that's where those margins were coming from! Big thumbs-up.

This revision is now accepted and ready to land.Oct 26 2018, 8:14 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kiconloader.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44264	213b266		Oct 26 2018, 8:04 PM	★	★
Diff 2	44266	030e65f	R302:9a94fd6edf0711bd7bf4f9c787b563a382f2e962	Oct 26 2018, 8:16 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
dd3545c68fe8	5fc9e3a97550	213b266fe14f	Stefan Brüns	[KIconLoader] Adjust emblem border depending on icon size (Show More…)	Oct 26 2018, 8:04 PM