| romangg |
| Frameworks | |
| Plasma |
This rework fixes several issues:
BUG: 350816
BUG: 269403
Ctrl-Alt-Y global shortcut works even when doing
"setxkbmap us; kglobalaccel5 & sleep 1; setxkbmap de;" while it did not
before. On some systems, this race happened on every login, now it works
reliably.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Note that the way it's done is copied from inspired by QXcbConnection.
I don't like it either though, so I'll try getting rid of the union.
| src/runtime/plugins/xcb/kglobalaccel_x11.cpp | ||
|---|---|---|
| 99–102 | Before there was a check to QX11Info::isPlatformX11(). Probably we don't need the check, but did you test on Wayland? | |
| 235 | case m_xkb_first_event:
if (m_xkb_first_event) {
...
}
default:
return false;Or directly do the switching on responseType with if-else statements. | |
| 258 | Might leak? Use xcb_key_symbols_free. | |
Pls do the coding style improvements and push.
| src/runtime/plugins/xcb/kglobalaccel_x11.cpp | ||
|---|---|---|
| 75 | ||
| 208–213 | ||
| 214 | https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces space and on same line as closing brace | |