| romangg |
| Frameworks | |
| Plasma |
This rework fixes several issues:
BUG: 350816
BUG: 269403
Ctrl-Alt-Y global shortcut works even when doing
"setxkbmap us; kglobalaccel5 & sleep 1; setxkbmap de;" while it did not
before. On some systems, this race happened on every login, now it works
reliably.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 4208 | |
| Build 4226: arc lint + arc unit |
| src/runtime/plugins/xcb/kglobalaccel_x11.cpp | ||
|---|---|---|
| 198–208 ↗ | (On Diff #44241) | I see what you doing, but don't do it. See below. |
| 233 ↗ | (On Diff #44241) | Cast to xcb_generic_event_t |
| 234 ↗ | (On Diff #44241) | Use pad0 (stupid name but you can get it as ref and name as you want) |
| 239 ↗ | (On Diff #44241) | Cast event to xcb_xkb_new_keyboard_notify_event_t. |
Note that the way it's done is copied from inspired by QXcbConnection.
I don't like it either though, so I'll try getting rid of the union.
| src/runtime/plugins/xcb/kglobalaccel_x11.cpp | ||
|---|---|---|
| 96 | Before there was a check to QX11Info::isPlatformX11(). Probably we don't need the check, but did you test on Wayland? | |
| 220 | case m_xkb_first_event:
if (m_xkb_first_event) {
...
}
default:
return false;Or directly do the switching on responseType with if-else statements. | |
| 264 | Might leak? Use xcb_key_symbols_free. | |
Pls do the coding style improvements and push.
| src/runtime/plugins/xcb/kglobalaccel_x11.cpp | ||
|---|---|---|
| 75 ↗ | (On Diff #44241) | |
| 225 ↗ | (On Diff #44241) | |
| 231 ↗ | (On Diff #44241) | https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces space and on same line as closing brace |