Use consistent size icon in OSD
ClosedPublic

Authored by davidedmundson on Oct 26 2018, 12:31 AM.

Details

Summary

The OSD's icon is based on the implicitSize of the IconItem.

For most icons this will be a hardcoded value from
KIconLoader::global()->currentSize

However, since bc33f0470d4d6bcbf30475f85b36705e8a99528b in
plasma-framework we sometimes return that value, sometimes will return the
source size of the underlying image depending on internal paths of how
the icon is loaded and whether it was in the plasma theme or not.

This patch overrides the implicitWidth given to the layout to be the
standard icon size.

BUG: 400083

Test Plan

Loaded the force kill window OSD.
Icon still looked the same size on breeze.

I didn't reproduce the issue in the bug

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptOct 26 2018, 12:31 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 26 2018, 12:31 AM
graesslin accepted this revision.Oct 26 2018, 4:16 AM
This revision is now accepted and ready to land.Oct 26 2018, 4:16 AM
This revision was automatically updated to reflect the committed changes.