Differential D16420

Sync desktop switch OSD font size to Plasma OSD font size
ClosedPublic
Actions

Authored by davidedmundson on Oct 25 2018, 1:12 AM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:fe07909cd8d2: [desktopchangeosd] Sync desktop switch OSD font size to Plasma OSD font size
Summary

Plasma's OSDs for volume/screens etc use PlasmaExtras.Heading, this
should to.

Also correct centering text to constrain the text element and align the
text within that bounding box. Previous code could have overflown in the
event of a really really long desktop name if we're resizing to the grid.

BUG: 356600

Test Plan

Switched desktop with OSD on
Tried with and without "show desktop layout indicators"

Diff Detail

Repository
R108 KWin
Branch
nov5
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4184
Build 4202: arc lint + arc unit
davidedmundson created this revision.Oct 25 2018, 1:12 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 25 2018, 1:12 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 25 2018, 1:12 AM
graesslin accepted this revision.Oct 26 2018, 4:44 PM
This revision is now accepted and ready to land.Oct 26 2018, 4:44 PM
Closed by commit R108:fe07909cd8d2: [desktopchangeosd] Sync desktop switch OSD font size to Plasma OSD font size (authored by davidedmundson). · Explain WhyOct 28 2018, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44195

View Options

scripts/desktopchangeosd/contents/ui/osd.qml

Loading...