Improve replacement text when action description is not provided
ClosedPublic
Actions

Authored by bruns on Oct 24 2018, 8:30 PM.

Details

Reviewers

ngraham
davidedmundson

Group Reviewers

Plasma

Commits

Summary

Split from D12498.

Repository

R121 Policykit (Polkit) KDE Agent

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bruns requested review of this revision.Oct 24 2018, 8:30 PM

AuthDialog.cpp
356	So I gather `.isEmpty()` works now?
359	I would prefer "not available" over "not provided", but I won't choose this as my hill to die on. :) Do we actually need to repeat the word 'Description' here?

AuthDialog.cpp
356	Yes.
359	There is no repetition here - the Polkit "<description>" is labeled "Action:" in the dialog.

AuthDialog.cpp
359	Btw, "not provided" is your own proposal ;-)

Thanks, this works.

AuthDialog.cpp
359	What!? I must be going senile already...

This revision is now accepted and ready to land.Oct 25 2018, 4:46 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			AuthDialog.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44183	2959f77		Oct 24 2018, 8:30 PM	★	★
Diff 2	44205	2959f77	R121:9cf71f4249508896052f358fb33dd34d13e163c3	Oct 25 2018, 12:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
dd28c91d3752	6b8ea479e3c1	2959f77c8c55	Stefan Brüns	Improve replacement text when action description is not provided (Show More…)	Oct 24 2018, 7:23 PM