There was no support for CLIST syntax highlighting so I decided to create this file to add support.
Details
- Reviewers
dhaumann cullmann - Group Reviewers
Framework: Syntax Highlighting - Commits
- R216:185b54827ab0: z/OS CLIST file syntax highlighting
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed.
data/syntax/clist.xml | ||
---|---|---|
3 ↗ | (On Diff #44182) | license="MIT" is missing. |
3 ↗ | (On Diff #44182) | kateversion="5.0", or are you indeed using an old Kate before Plasma5? |
61 ↗ | (On Diff #44182) | Maybe rename Commentar 1 to simply Comment? It seems you copy & pasted the file :) |
62 ↗ | (On Diff #44182) | Please use IncludeRules with ##Alerts, look into other highlighting files how this is done. |
69 ↗ | (On Diff #44182) | Please remove the hard coded color. Hard coded colors are an issue with different color schemes. See https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ for more default styles. |
Example CLIST can be viewed here: https://gist.githubusercontent.com/mainframed/9e9c85b7a13186e7ca51b5b47d90b575/raw/1e19fede7d203585b213d2f20700ed08baac9e07/protall.clist
Looking at the code repo I wasn't sure exactly where to include the code examples.
I can add the test for you, otherwise this look ok to go in.
Thanks for the contribution.
The Alert include is missing, but I am not sure if it is really needed ;=)