Creating new syntax highlighting file for Job Control Language (JCL)
ClosedPublic

Authored by phily on Oct 24 2018, 8:25 PM.

Details

Summary

There is currently no support for JCL (Job Control Language) syntax highlighting. This XML file adds that support.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
phily created this revision.Oct 24 2018, 8:25 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptOct 24 2018, 8:25 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
phily requested review of this revision.Oct 24 2018, 8:25 PM
dhaumann requested changes to this revision.Oct 26 2018, 5:55 AM
dhaumann added a subscriber: dhaumann.

Please add a small test file and explain what this highlighting language is used for :)

data/syntax/jcl.xml
3 ↗(On Diff #44181)

kateversion="5.0" and license="MIT"

128 ↗(On Diff #44181)

Use column="0" and remove leading ^. Or do you mean firstNonSpace="true"?

This revision now requires changes to proceed.Oct 26 2018, 5:55 AM
phily updated this revision to Diff 44277.Oct 27 2018, 4:59 AM
phily marked an inline comment as done.

Making changes based on reviewer comments.

phily marked an inline comment as done.Oct 27 2018, 5:01 AM

Thank you for the feedback. I've gone and updated the syntax file to explain what JCL is and remove the ^ from the regex. Thank you for the suggestions.

Hi, could one remove the two hard-coded colors and just use a different builtin defStyleNum?

Beside that, have you some small example script that we could add as auto-test?

e.g. something perhaps a bit larger than the snippets I can find on

https://en.wikipedia.org/wiki/Job_Control_Language

(and that has no license issues)

cullmann requested changes to this revision.Oct 27 2018, 2:45 PM
This revision now requires changes to proceed.Oct 27 2018, 2:45 PM
phily updated this revision to Diff 44454.Oct 29 2018, 5:58 PM

Adding test file for JCL and making removing hard coded colors.

phily updated this revision to Diff 44457.Oct 29 2018, 6:27 PM
  • Added JCL test program as well as fixing recommendations (no hard coded colors)
  • Added new highlighting of steps (vs program options)
cullmann accepted this revision.Nov 1 2018, 3:52 PM

nice, thanks, will merge this!

Merged ;=)

Git commit a2032c52bf1b5ced774c2f58994aaeb4d233f25a by Christoph Cullmann, on behalf of Phil Young.
Committed on 01/11/2018 at 15:54.
Pushed by cullmann into branch 'master'.

Creating new syntax highlighting file for Job Control Language (JCL)

Differential Revision: https://phabricator.kde.org/D16415

A +43 -0 autotests/folding/test.jcl.fold
A +50 -0 autotests/html/test.jcl.html
A +43 -0 autotests/input/test.jcl
A +43 -0 autotests/reference/test.jcl.ref
A +170 -0 data/syntax/jcl.xml

https://commits.kde.org/syntax-highlighting/a2032c52bf1b5ced774c2f58994aaeb4d233f25a

This revision was not accepted when it landed; it landed in state Needs Review.Nov 1 2018, 4:06 PM
This revision was automatically updated to reflect the committed changes.