Differential D16401

[effects] Recreate shell client connections after compositor settings have been changed
ClosedPublic
Actions

Authored by zzag on Oct 24 2018, 2:45 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:722af0215339: [effects] Recreate shell client connections after compositor settings have been…
Summary

If the animation speed was changed, then EffectsHandler will be destroyed
and created again.

Because we don't create connections to monitor state of Wayland clients
in EffectsHandler constructor, effects like the Magic lamp won't work
after changing compositor settings.

BUG: 400240

Test Plan
  • Changed animation speed;
  • Minimized a Wayland client.

Diff Detail

Repository
R108 KWin
Branch
recreate-effectwindow-connections
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4161
Build 4179: arc lint + arc unit
zzag created this revision.Oct 24 2018, 2:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 24 2018, 2:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 24 2018, 2:45 PM
zzag planned changes to this revision.Oct 24 2018, 2:47 PM
zzag retitled this revision from [effects] Setup connections for pre-existing Wayland clients to [effects] Monitor state of pre-existing Wayland clients.

the title is still lame..

zzag requested review of this revision.Oct 24 2018, 2:59 PM
zzag retitled this revision from [effects] Monitor state of pre-existing Wayland clients to [effects] Recreated shell client connections after compositor settings have been changed.
zzag retitled this revision from [effects] Recreated shell client connections after compositor settings have been changed to [effects] Recreate shell client connections after compositor settings have been changed.
davidedmundson accepted this revision.Oct 26 2018, 11:13 AM
This revision is now accepted and ready to land.Oct 26 2018, 11:13 AM
Closed by commit R108:722af0215339: [effects] Recreate shell client connections after compositor settings have been… (authored by zzag). · Explain WhyOct 26 2018, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.cpp (8 lines)

Diff 44155

View Options

effects.cpp

Loading...