Remove the last deprecated thing (Quanta+ is dead and its plugin best be on its way) and mention of kdelibs4support in CMakeLists.txt, sort headers in some files.
Details
- Reviewers
ltoscano aacid - Group Reviewers
KDE Applications - Commits
- R443:61ba7644d04d: Port KImageMapEditor away from kdelibs4support
- Start KImageMapEditor (can be done via command line with an image file name).
- Add some map and save it.
- Check that the map works in a browser.
- Load the image map HTML again into the editor, check if everything is in place.
Diff Detail
- Repository
- R443 KImageMapEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Isn't it needed for the KPart to work? I had a work in progress branch but it's basically a complete rewrite.
So I'm not against this change; while it would be nice to have a complete port, it's probably not really important.
Yes, that was a bit of surprise for me too. But it works somehow.
Can someone test and confirm my conclusion that it is not needed for KImageMapEditor as a standalone application (afaik no other application can use it now as a plugin)?
This patch restores the kpart code to be "conforming to spec"
https://paste.kde.org/p9pooyklc
It doesn't really matter much since kimagemapeditor is not using kpart loading but directly instantiating the class (which is a bit weird tbh).
But as said, with this patch I could just change okularpart to kimagemapeditor in the okular shell and it loaded the kimagemapeditor part (then it didn't really show anything not sure if either because okular shell assumes to much about the part it loads or because the imagemapeditor assumes too much about it's holder).
Anyway i think we have two options:
- Use my patch and if someone ever really wants to load kimagemapeditor as a part fix it
- Stop shipping kimagemapeditorpart.desktop and pretending kimagemapeditor is a part we expect the outside world to use.
I'm unsure which i think it's a better plan/idea. So comment! :D