fix some layout limitations in media play list
ClosedPublic
Actions

Authored by mgallien on Oct 23 2018, 3:24 PM.

Details

Reviewers

januz
astippich

Commits

Summary

fix warning about binding loop

allow to keep the tool buttons at a fixed position even with an empty
play list

Test Plan

no more binding loop or tool buttons moving out to the left with an empty playlist

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Oct 23 2018, 3:24 PM

mgallien created this revision.

I'm not seeing a difference with and without your patch, but since it's less code, go for it.

This revision is now accepted and ready to land.Oct 31 2018, 8:24 PM

I'm going to land this his for you to avoid some potential conflicts

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/qml/MediaPlayListView.qml (92 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44117	2d812af		Oct 23 2018, 3:24 PM	★	★
Diff 2	45630	4ace01e	R255:a213020030f30c5050a1913c168fdadf0294f227	Nov 17 2018, 9:18 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a864383274b4	9f917313433a	2d812af35e77	Matthieu Gallien	fix some layout limitations in media play list (Show More…)	Oct 23 2018, 3:22 PM