Differential D16381

Only use wl-shell for the ksmserver greeters on Qt < 5.12
ClosedPublic
Actions

Authored by fvogt on Oct 23 2018, 7:53 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:790f5bf48f2b: Only use wl-shell for the ksmserver greeters on Qt < 5.12
Summary

Apparently wl-shell fullscreen is broken on Qt 5.12 now, but we don't need this
workaround anymore.

BUG: 399918

Test Plan

Clicked on logout, got the greeter. Without this patch, the greeter
was not visible.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Oct 23 2018, 7:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2018, 7:53 AM
fvogt requested review of this revision.Oct 23 2018, 7:53 AM
davidedmundson added a subscriber: davidedmundson.Oct 23 2018, 9:43 AM

Do Qt know it's broken? It shouldn't be

fvogt added a comment.Oct 23 2018, 3:04 PM
In D16381#347483, @davidedmundson wrote:

Do Qt know it's broken? It shouldn't be

Not yet. There is a warning on stderr that wl-shell shouldn't be used though.

davidedmundson accepted this revision.Oct 23 2018, 3:13 PM
This revision is now accepted and ready to land.Oct 23 2018, 3:13 PM
Closed by commit R120:790f5bf48f2b: Only use wl-shell for the ksmserver greeters on Qt < 5.12 (authored by fvogt). · Explain WhyOct 23 2018, 3:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44115

View Options

ksmserver/logout-greeter/main.cpp

Loading...
View Options

ksmserver/switchuser-greeter/main.cpp

Loading...