Do not ignore translations that are the same as the original
ClosedPublic

Authored by aacid on Oct 22 2018, 10:35 PM.

Details

Reviewers
arichardson
Summary

We need to include them because if the user has configured 3 languages, we want the "best langauge" translation to be used, and not the "language that has a translation different from original".

i.e user uses lang X, Y, Z

original text is "Moo"
translation of Moo for the languages are
X: Moo
Y: Moo
Z: MooB

We want the user to see Moo because it's X not MooB from Z

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
aacid requested review of this revision.Oct 22 2018, 10:35 PM
aacid created this revision.
arichardson accepted this revision.Oct 23 2018, 6:20 AM

Makes sense, I didn't think about multiple languages being set when I wrote that code.

This revision is now accepted and ready to land.Oct 23 2018, 6:20 AM
aacid closed this revision.Oct 23 2018, 9:35 PM

Pushed