Using the system palette for drawing the month- and agendaitem.
ClosedPublic

Authored by ognarb on Oct 22 2018, 8:06 PM.

Details

Summary

Before:


After:
breeze dark:

breeze:

arc:

oxygen:

Agenda:
Before:


After
breeze dark:

breeze:

Diff Detail

Repository
R76 PIM: Event Views
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4133
Build 4151: arc lint + arc unit
ognarb created this revision.Oct 22 2018, 8:06 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 22 2018, 8:06 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ognarb requested review of this revision.Oct 22 2018, 8:06 PM
ognarb edited the summary of this revision. (Show Details)Oct 22 2018, 8:33 PM
ognarb edited the summary of this revision. (Show Details)Oct 22 2018, 8:45 PM
ognarb updated this revision to Diff 44087.Oct 22 2018, 9:29 PM

Fixing color in agenda

Looking pretty good so far. Nice job!

mlaurent requested changes to this revision.Oct 23 2018, 9:35 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/agenda/agenda.cpp
1531–1536

REmove code if it's always false please

1551

same

1615

same

1671

same

src/month/monthscene.cpp
249–254

same

308

same

This revision now requires changes to proceed.Oct 23 2018, 9:35 AM
ognarb updated this revision to Diff 44122.Oct 23 2018, 3:48 PM

Add a new preference enabled by default to choose the follow the system color or not

ognarb marked 6 inline comments as done.Oct 23 2018, 4:20 PM

I still have a problem, the new config don't appear in the gui. Does someone know how kcfg works? I already read https://techbase.kde.org/Development/Tutorials/Using_KConfig_XT but it didn't help.

src/agenda/agenda.cpp
1531–1536

Like I said it's WIP. I want to add a button in the config, so that the user can choose between using the system color scheme or manually set the color using the old system.

I still have a problem, the new config don't appear in the gui. Does someone know how kcfg works? I already read https://techbase.kde.org/Development/Tutorials/Using_KConfig_XT but it didn't help.

KOrganizer is not using KConigXT to generate UI, but only to generate a C++ class that represents the configuration object. You have to write the GUI code yourself. In this case the generated class is wrapped in src/prefs.cpp and the UI is implemented in korganizer.git/src/prefs/koprefsdialog.cpp

ognarb marked 2 inline comments as done.Oct 23 2018, 9:19 PM

@dvratil Thanks :)

src/agenda/agenda.cpp
1531–1536

I changed the condition

ognarb marked an inline comment as done.Oct 23 2018, 10:48 PM

@dvratil I just added the config in Korganizer D16393.

mlaurent requested changes to this revision.Oct 24 2018, 4:59 AM
mlaurent added inline comments.
src/prefs.cpp
559 ↗(On Diff #44122)

coding style: add new line before {

563 ↗(On Diff #44122)

same

This revision now requires changes to proceed.Oct 24 2018, 4:59 AM
ognarb updated this revision to Diff 44187.Oct 24 2018, 9:09 PM
ognarb marked 2 inline comments as done.

Coding style

ognarb marked an inline comment as done.Oct 24 2018, 10:35 PM

mlaurent accepted this revision.Oct 25 2018, 11:54 AM

Seems ok for me.

This revision is now accepted and ready to land.Oct 25 2018, 11:54 AM
ognarb edited the summary of this revision. (Show Details)Oct 25 2018, 12:26 PM
ognarb added a comment.EditedOct 25 2018, 1:47 PM

Seems ok for me.

Thanks, could you also look at D16393?

This revision was automatically updated to reflect the committed changes.