Differential D16368

Swap Trash/Delete when Shift is used while the menu is open
ClosedPublic
Actions

Authored by hein on Oct 22 2018, 8:19 AM.

Details

Reviewers
ngraham
broulik
davidedmundson
Commits
R119:c4285ed1b407: Swap Trash/Delete when Shift is used while the menu is open
Summary

Matching Dolphin.

BUG:395155

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4121
Build 4139: arc lint + arc unit
hein created this revision.Oct 22 2018, 8:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2018, 8:19 AM
hein requested review of this revision.Oct 22 2018, 8:19 AM
davidedmundson accepted this revision.Oct 22 2018, 11:05 AM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
containments/desktop/plugins/folder/foldermodel.cpp
653

you delete the menu when the menu isn't open, you won't get any events

This revision is now accepted and ready to land.Oct 22 2018, 11:05 AM
broulik added inline comments.Oct 22 2018, 11:32 AM
containments/desktop/plugins/folder/foldermodel.cpp
1854

Use four argument connect since now you access this but given you delete the menu anyway, this change probably isn't neccessary to begin with

ngraham added a comment.Oct 22 2018, 2:18 PM

Thanks Eike! Any chance this can go into the 5.12 branch?

hein updated this revision to Diff 44091.Oct 23 2018, 5:57 AM

Simplify patch.

davidedmundson accepted this revision.Oct 23 2018, 10:48 AM
Closed by commit R119:c4285ed1b407: Swap Trash/Delete when Shift is used while the menu is open (authored by hein). · Explain WhyOct 24 2018, 7:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44063

View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...