Swap Trash/Delete when Shift is used while the menu is open

Authored by hein on Oct 22 2018, 8:19 AM.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Oct 22 2018, 8:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2018, 8:19 AM
hein requested review of this revision.Oct 22 2018, 8:19 AM
davidedmundson accepted this revision.Oct 22 2018, 11:05 AM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.

you delete the menu when the menu isn't open, you won't get any events

This revision is now accepted and ready to land.Oct 22 2018, 11:05 AM
broulik added inline comments.Oct 22 2018, 11:32 AM

Use four argument connect since now you access this but given you delete the menu anyway, this change probably isn't neccessary to begin with

Thanks Eike! Any chance this can go into the 5.12 branch?

hein updated this revision to Diff 44091.Oct 23 2018, 5:57 AM

Simplify patch.

davidedmundson accepted this revision.Oct 23 2018, 10:48 AM
This revision was automatically updated to reflect the committed changes.