Fix crash with icon dialog
AbandonedPublic
Actions

Authored by cfeck on Oct 22 2018, 3:57 AM.

Details

Reviewers

None

Group Reviewers

Summary

Revert part of fea52a4f204fd44d9a45e78a663964c326687e33 which causes a crash in sorting code. Apparently, std::sort applies different semantics?

BUG: 398766
FIXED-IN: 5.52.0

Repository

R302 KIconThemes

Lint

Lint Skipped

Unit

Unit Tests Skipped

cfeck created this object with visibility "cfeck (Christoph Feck)".

cfeck requested review of this revision.Oct 22 2018, 3:57 AM

cfeck changed the visibility from "cfeck (Christoph Feck)" to "Public (No Login Required)".

const QString fileName2 = path2.mid(path2.lastIndexOf(QLatin1Char('/')) + 1);

no?

Good spot, and this is already fixed, but unfortunately was too late for the 5.51 tag.

			Path	Packages
M			src/kicondialog.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44055			Oct 22 2018, 3:42 AM	★	★