Edit Profile Dialog: Fix "Smooth fonts" preview
ClosedPublic

Authored by mglb on Oct 21 2018, 6:52 PM.

Details

Summary

setStyleHint() resets styleStrategy (which has information about
font smoothing) when the second argument is missing.

Test Plan
  • SettingsEdit current profile...Appearance
  • Unselect/select "Smooth fonts" checkbox

Actual result: text rendering in the main terminal window does not
change.
Expected result: text rendering in the main terminal window should
use smoothing or not, depending on the checkbox state. The option change
should be visible instantly, without clicking OK or Apply.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb requested review of this revision.Oct 21 2018, 6:52 PM
mglb created this revision.
mglb edited the summary of this revision. (Show Details)Oct 21 2018, 7:10 PM
mglb edited the test plan for this revision. (Show Details)

It works here if you have it enabled and then toggle it. But if you have it off and then toggle it, no change in terminal.

mglb updated this revision to Diff 44125.Oct 23 2018, 6:12 PM

Fix broken preview when antialiasing is disabled

hindenburg accepted this revision.Oct 24 2018, 2:13 PM
This revision is now accepted and ready to land.Oct 24 2018, 2:13 PM
This revision was automatically updated to reflect the committed changes.