Differential D16360

handle empty metadata more gracefully in metadataview
ClosedPublic
Actions

Authored by astippich on Oct 21 2018, 6:41 PM.

Details

Reviewers
mgallien
Commits
R255:291261a25d95: handle empty metadata more gracefully in metadataview
Summary

show a label when no metadata is available and check
for more properties. also, hide rating if it is zero

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Oct 21 2018, 6:41 PM
astippich created this revision.
mgallien requested changes to this revision.Oct 23 2018, 3:51 PM
mgallien added inline comments.
src/qml/MediaTrackMetadataView.qml
78–80

Something is probably wrong here as the window height is too small and I barely see the close button.

src/trackdatahelper.h
240–241

This is not needed. The method from the base class will be found for the property reader method.

This revision now requires changes to proceed.Oct 23 2018, 3:51 PM
astippich updated this revision to Diff 44123.Oct 23 2018, 5:37 PM
  • remove leftover
astippich added inline comments.Oct 23 2018, 5:37 PM
src/qml/MediaTrackMetadataView.qml
78–80

I can't reproduce, it's working here...

src/trackdatahelper.h
240–241

Sorry for the leftover

mgallien accepted this revision.Nov 17 2018, 8:37 AM
This revision is now accepted and ready to land.Nov 17 2018, 8:37 AM
Closed by commit R255:291261a25d95: handle empty metadata more gracefully in metadataview (authored by astippich). · Explain WhyNov 17 2018, 9:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45626

View Options

src/qml/MediaTrackMetadataView.qml

Loading...
View Options

src/trackdatahelper.h

Loading...
View Options

src/trackdatahelper.cpp

Loading...