Differential D1634

Fix imports for several built-in QML modules
ClosedPublic
Actions

Authored by cordlandwehr on May 18 2016, 8:14 PM.

Details

Reviewers
mwolff
apol
brauch
kfunk
Group Reviewers
KDevelop
Commits
R32:7179a2bfcaa7: Fix imports for several built-in QML modules
R32:a48258b6a857: Fix imports for several built-in QML modules
R32:dcaa3bdf4e15: Simplify file checks
Summary

This patch adds several missing special cases for QML modules that
previously were not found correctly. The additional unit test
ensures that the paths are really found and should work on a standard
CI system with recent Qt.

Test Plan

added unit test and now it passes

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr updated this revision to Diff 3866.May 18 2016, 8:14 PM
cordlandwehr retitled this revision from to Fix imports for several built-in QML modules.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added reviewers: KDevelop, brauch, kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 18 2016, 8:14 PM
apol added a subscriber: apol.May 18 2016, 11:15 PM
apol added inline comments.
languages/qmljs/duchain/cache.cpp
84–91

Make const? maybe use the list initializer?

107–111

Looks to me that it's always called plugins.qmltypes. It would be much faster if we can keep it to just a QFile::exists(pathString+"/plugins.qmltypes")

cordlandwehr updated this revision to Diff 3891.May 19 2016, 4:33 PM
  • Simplify file checks
apol accepted this revision.May 23 2016, 10:26 PM
apol added a reviewer: apol.

seems to fix issues, the few things I saw are solved, I'd say get it in.

This revision is now accepted and ready to land.May 23 2016, 10:26 PM
kfunk accepted this revision.May 24 2016, 6:42 AM
kfunk edited edge metadata.
Closed by commit R32:a48258b6a857: Fix imports for several built-in QML modules (authored by cordlandwehr). · Explain WhyMay 24 2016, 6:26 PM
This revision was automatically updated to reflect the committed changes.
cordlandwehr marked 2 inline comments as done.

Revision Contents
Changeset List

Diff 3972

View Options

languages/qmljs/duchain/cache.cpp

Loading...
View Options

languages/qmljs/duchain/tests/test_qmljsdeclarations.h

Loading...
View Options

languages/qmljs/duchain/tests/test_qmljsdeclarations.cpp

Loading...