Allow double click in readonly mode
Fix bug with existing assistant, when we load read-only worksheet from empty worksheet with existing backend
Fix bug with existing entry cursor, when we load read-only worksheet from empty worksheet with existing backend

Harbormaster completed remote builds in B4097: Diff 44017.Oct 21 2018, 12:44 PM

Remove entry cursor reseting (on master already)

Harbormaster completed remote builds in B4147: Diff 44120.Oct 23 2018, 3:30 PM

asemke added inline comments.Oct 27 2018, 5:41 PM

src/cantor_part.cpp
396	are these disconnects really required? Will it be possible for worksheet to send these signals if it's read-only?

Some code improvments

Harbormaster completed remote builds in B4247: Diff 44323.Oct 27 2018, 6:10 PM

sirgienko marked an inline comment as done.Oct 27 2018, 6:10 PM

asemke accepted this revision.Oct 27 2018, 6:33 PM

This revision is now accepted and ready to land.Oct 27 2018, 6:33 PM

So, @filipesaraiva, what do you think about it?
We plan to merge this code to master November 7, if there aren't objections.

Well, @filipesaraiva, I hope, that you have read my message and you don't write answer, because you haven't objections.
The release is soon and Alexander agree with this patch, so I merge this patch to master.
We could return to this theme later, after 18.12, if needed.

Closed by commit R55:873631d99963: [T4760] Add readonly feature for Worksheet: if user open worksheet file and… (authored by sirgienko). · Explain WhyNov 7 2018, 4:52 PM

This revision was automatically updated to reflect the committed changes.

sirgienko mentioned this in D15276: Add readOnly feature for Cantor's Worksheet.Nov 7 2018, 4:54 PM

			Path	Packages
M			src/cantor_part.h (4 lines)
M			src/cantor_part.cpp (94 lines)
M			src/lib/expression.cpp (5 lines)
M			src/worksheet.h (4 lines)
M			src/worksheet.cpp (107 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43966	8367cda		Oct 20 2018, 12:50 PM	★	★
Diff 2	43992	8367cda	Some improvements	Oct 20 2018, 7:20 PM	★	★
Diff 3	43996	8367cda	Add availability check for default session	Oct 20 2018, 8:13 PM	★	★
Diff 4	44012	8367cda	Fix bug with load	Oct 21 2018, 10:07 AM	★	★
Diff 5	44013	8367cda	Another improvments	Oct 21 2018, 10:13 AM	★	★
Diff 6	44017	8367cda	- Allow double click in readonly mode	Oct 21 2018, 12:44 PM	★	★
Diff 7	44120	8367cda	Remove entry cursor reseting (on master already)	Oct 23 2018, 3:30 PM	★	★
Diff 8	44323	8367cda	Some code improvments	Oct 27 2018, 6:10 PM	★	★
Diff 9	45058	a48f67d	R55:873631d99963b8ce15525c1d68ae27a5d5eff84f	Nov 7 2018, 4:47 PM	★	★

Add readOnly feature for Cantor's Worksheet [v2]
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 45058

src/cantor_part.h

src/cantor_part.cpp

src/lib/expression.cpp

src/worksheet.h

src/worksheet.cpp

Add readOnly feature for Cantor's Worksheet [v2]ClosedPublicActions