Update libdbusmenuqt folder
ClosedPublic

Authored by Zren on Oct 19 2018, 8:37 PM.

Details

Summary

I needed to add include(ECMQtDeclareLoggingCategory) to the root CMakeLists.txt to get it to compile.

https://github.com/KDE/plasma-workspace/tree/master/libdbusmenuqt

I've no idea why the annotations for the qdbus ItemsPropertiesUpdated signal used In0 instead of Out0.

https://github.com/kotelnik/plasma-applet-active-window-control/blob/master/plugin/libdbusmenuqt/com.canonical.dbusmenu.xml#L5

Diff Detail

Repository
R884 Active Window Control Applet for Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Zren created this revision.Oct 19 2018, 8:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 19 2018, 8:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Zren requested review of this revision.Oct 19 2018, 8:37 PM
broulik requested changes to this revision.Oct 20 2018, 7:15 AM
broulik added a subscriber: broulik.

Can you rebase this patch? I already made it use categorized logging a few weeks ago. There's also random other bits of changes, be more specific what the change should do, "update" isn't

This revision now requires changes to proceed.Oct 20 2018, 7:15 AM
broulik resigned from this revision.Oct 20 2018, 7:15 AM

Oh, wait, appmenu thing has its own copy of libdbusmenu-qt?

Zren added a comment.Oct 20 2018, 8:11 AM

Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the /usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2, but I wanted to update all the common code first before making major refactoring.

Zren added a comment.EditedOct 20 2018, 5:05 PM

KNotifications provides an example of linking to dbusmenu-qt5:
https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49

However it contains an older version of dbusmenu. plasma-workspace ships a patched version.

We can't link to the plasma-workspace libdbusmenuqt library afaik.

  • /usr/lib/x86_64-linux-gnu/cmake/

Yeah, I'm not 100% sure why the Active Window Control widget needs it.

AWC started out as some github project without asking us to make a plugin.

Which would be (IMHO) the best path moving forwards.

Note also libdbusmenu-qt upstream is both export and import, whereas the p-w part is only import.

Zren added a comment.Oct 24 2018, 5:33 PM

For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on.

This revision was not accepted when it landed; it landed in state Needs Revision.Oct 24 2018, 7:51 PM
This revision was automatically updated to reflect the committed changes.