Add accessibility information to desktop icons
ClosedPublic

Authored by chempfling on Oct 19 2018, 9:29 AM.

Details

Summary

This adds an accessibility name and role to the icons on the desktop.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chempfling requested review of this revision.Oct 19 2018, 9:29 AM
chempfling created this revision.
shubham set the repository for this revision to R119 Plasma Desktop.Oct 19 2018, 9:54 AM
shubham added a subscriber: Plasma.
Restricted Application edited projects, added Plasma; removed Plasma Accessibility. · View Herald TranscriptOct 19 2018, 9:54 AM
Restricted Application edited subscribers, added: plasma-devel; removed: Plasma. · View Herald Transcript
gladhorn accepted this revision.Oct 19 2018, 12:44 PM
gladhorn added inline comments.
containments/desktop/package/contents/ui/FolderItemDelegate.qml
45

Is Canvas what Gnome uses for desktop icons? I'm fine with this, since I don't have a better suggestion.

This revision is now accepted and ready to land.Oct 19 2018, 12:44 PM
chempfling added inline comments.Oct 19 2018, 1:21 PM
containments/desktop/package/contents/ui/FolderItemDelegate.qml
45

Canvas is used by Nautilus. The default filemanager.

Joanie would prefer the Role „Icon“ what we didn’t find in the documentation.
Just „Graphics“ what is to be assumed as image or picture.

See joanies answer:
https://mail.gnome.org/archives/orca-list/2018-October/msg00215.html

Canvas works as exceped, i tried.

chempfling marked 2 inline comments as done.Oct 19 2018, 1:22 PM

Do i need to do anythin else to get it into master?

I guess we can go with this for now, let's be pragmatic. Qt doesn't have icon or desktop_icon at the moment. I can add, if Joanie suggests doing that on the Orca mailing list.

Ok, so nothing to do then. Is this merged automatically once per day or something? Or how do i get the patch into master now? I mark the task as done.

hein added a comment.Oct 22 2018, 5:01 AM

I'll land it for you (it needs a manual step, which requires a dev account - which you should eventually apply for if you wind up contributing regularly!).

This revision was automatically updated to reflect the committed changes.
In D16309#347071, @hein wrote:

I'll land it for you (it needs a manual step, which requires a dev account - which you should eventually apply for if you wind up contributing regularly!).

Ok Thanks,
I ll try to get an dev acount. let me check how to i get one.