Differential D16306

[Codecs] Remove unneeded const_cast
ClosedPublic
Actions

Authored by bruns on Oct 18 2018, 11:20 PM.

Details

Reviewers
poboiko
ngraham
dfaure
Group Reviewers
Baloo
Frameworks
Commits
R293:2e3dafe5a892: [Codecs] Remove unneeded const_cast
Summary

QByteArray accepts a const char* in the constructor, no need to cast
the const away.
Also make it obvious we are using the const overload of data() by
replacing it with constData().

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 18 2018, 11:20 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 18 2018, 11:20 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 18 2018, 11:20 PM
dfaure accepted this revision.Oct 19 2018, 7:25 AM
This revision is now accepted and ready to land.Oct 19 2018, 7:25 AM
Closed by commit R293:2e3dafe5a892: [Codecs] Remove unneeded const_cast (authored by bruns). · Explain WhyOct 19 2018, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/codecs/postingcodec.cpp (4 lines)

Diff 43910

View Options

src/codecs/postingcodec.cpp

Loading...