Added video to breadcrumb navigation and new images for primary action buttons
ClosedPublic

Authored by fabianr on Oct 18 2018, 10:42 AM.

Details

Summary

Added a videos showing the use of breadcrumb navigation and primary action buttons in plasma mobile

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
breadcrumb
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4305
Build 4323: arc lint + arc unit
fabianr requested review of this revision.Oct 18 2018, 10:42 AM
fabianr created this revision.
mart added a subscriber: mart.Oct 18 2018, 11:26 AM
mart added inline comments.
source/components/editing/swipelistitem.rst
50 ↗(On Diff #43859)

some comments on the video:
*the slide of the item doesn't seem to be animated?

  • as is an example for mobile, it should use either Material or Plasma as QT_QUICK_CONTROLS_STYLE
  • the listview and list items are all gray: is it the default color scheme? they should be white-ish by default
  • the search field is on top: one of the points of kirigami is to be as bottom-heavy as possible
  • fonts of the header in the desktop version seems to be slim as intended, but on the mobile version they are pretty fat.. is it on the same machine?
source/patterns/navigation/breadcrumb.rst
20
  • same comments about colors and style of the other one
  • there is a weird shadow creeping in on the first two list elements?
fabianr updated this revision to Diff 43866.Oct 18 2018, 1:10 PM
  • Added animation to the swipe movement. Recreated the videos with Plasma style.
fabianr added inline comments.Oct 18 2018, 1:13 PM
source/components/editing/swipelistitem.rst
50 ↗(On Diff #43859)

QT_QUICK_CONTROLS_STYLE is now Plasma
The slide of the is now animated

fabianr updated this revision to Diff 44237.Oct 26 2018, 6:51 AM
  • Small improvement in the way touch and clicks are simulated.
  • Improved options for click()
  • Removed video from swipelistitem, because the swipe doesn't work for now. Added images for primary action buttons. Changed simulate click to qml only.
fabianr retitled this revision from Added videos to breadcrumb navigation and swipelistitem for mobile. to Added video to breadcrumb navigation and new images for primary action buttons.Oct 26 2018, 6:53 AM
fabianr edited the summary of this revision. (Show Details)
fabianr added reviewers: mart, bshah.
fabianr updated this revision to Diff 44412.Oct 29 2018, 10:00 AM
  • Added screenshot for primary action on desktop in a toolbar

Not bad! Two ideas for improvement:

  • In the breadcrumb video, it's not obvious what list item was tapped on to go to the contact page. It happens really fast and I didn't see any kind of simulated touch indicator
  • For the primary action button image, I think we should try to reach some kind of consensus regarding button background coloring on the desktop. It's colored on mobile, and for the most part it's colored in Discover (AFAIK the only user of the Primary Action Button concept on the desktop). We might want to consider coloring the background with the default blue unless that color is overridden by the app itself for whatever reason.
ngraham accepted this revision.Oct 29 2018, 12:58 PM

Let's land this while we work on the above issues in parallel. :)

This revision is now accepted and ready to land.Oct 29 2018, 12:58 PM
fabianr closed this revision.Oct 29 2018, 1:03 PM