ArtColorSel: caching, fixes for crashes
ClosedPublic

Authored by amedonosova on Oct 18 2018, 5:31 AM.

Details

Summary

Main part of this diff is caching of selector parts, so it does not get redrawn all the time.

Includes changes to prevent crashes related to bug 399860.

Foreground and background color indicator now display correctly when color profile changes (e.g. are shown as gray if profile is set to grayscale).

CCBUG: 399860

Diff Detail

Repository
R37 Krita
Branch
amedonosova/artcolorsel-refactor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4205
Build 4223: arc lint + arc unit
amedonosova created this revision.Oct 18 2018, 5:31 AM
Restricted Application added a reviewer: Krita. · View Herald TranscriptOct 18 2018, 5:31 AM
Restricted Application added a project: Krita. · View Herald Transcript
amedonosova requested review of this revision.Oct 18 2018, 5:31 AM
amedonosova updated this revision to Diff 43841.EditedOct 18 2018, 6:25 AM
  • ArtColorSel: reinitialize colors after canvas change
amedonosova retitled this revision from Summary: ArtColorSel: cache the parts, so it's not redrawn every time to Summary:ArtColorSel: cache the parts, so it's not redrawn every time.Oct 18 2018, 6:27 AM
amedonosova edited the summary of this revision. (Show Details)
amedonosova edited the summary of this revision. (Show Details)
amedonosova retitled this revision from Summary:ArtColorSel: cache the parts, so it's not redrawn every time to ArtColorSel: cache the parts, so it's not redrawn every time.
amedonosova retitled this revision from ArtColorSel: cache the parts, so it's not redrawn every time to ArtColorSel: caching, fixes for crashes.Oct 21 2018, 7:37 PM
amedonosova edited the summary of this revision. (Show Details)

Hi, @amedonosova!

The initial idea of implementing KisDisplayColorConverter was to avoid other classes depending on big fat KisCanvas class. Why exactly this dependency was needed?

Hi, @amedonosova!

The initial idea of implementing KisDisplayColorConverter was to avoid other classes depending on big fat KisCanvas class. Why exactly this dependency was needed?

Hi, @dkazakov,

thanks for the review and for the information. I will revert this part and update, the diff. I think I was working on some memory access issues, but I cannot see now how this would help :)

  • ArtColorSel: reinitialize colors after canvas change
  • Revert "ArtColorSel: pass KisCanvas2 through to KisColor"
  • ArtColorSel: fixes dirty states on toggling gamut mask
  • ArtColorSel: limit font size searches for value scale numbers
amedonosova edited the summary of this revision. (Show Details)Oct 26 2018, 3:51 PM
rempt accepted this revision.Oct 29 2018, 12:11 PM
This revision is now accepted and ready to land.Oct 29 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.