add some more tags for asf audio files
Details
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
for some reason the TagLib::ASF::File tag() function returns only an invalid pointer, so I decided to use the dynamic_cast here.
src/extractors/taglibextractor.cpp | ||
---|---|---|
721 | // 0->0, 1->2, 25->4, 50->6, 75->8, 99->10 | |
737 | you don't need the isEmpty() here, as you iterate over it. | |
738 | I think you can write instead: | |
740 | this makes me always wonder why we don't do: // decltype(data.albumArtists) == QStringList for (attribute : lstAsf) { QString t = TStringToQString(attribute.toString()); data.albumArtists << contactsFromString(t); } | |
src/extractors/taglibextractor.h | ||
28 | Side note - I think tfilestream.h is no longer needed. |
src/extractors/taglibextractor.cpp | ||
---|---|---|
740 | Yeah, there is a lot of unneccesary stuff in there that must be cleaned up. But before I get to that, I would like to add tests for multiple entries, and before that we have to agree how the output of mutliple entries shall look like, which brings me to D12950 :) | |
src/extractors/taglibextractor.h | ||
28 | Is it okay if I push this directly? |
Add the comment, otherwise its fine.
src/extractors/taglibextractor.cpp | ||
---|---|---|
855 | Can you add a comment here for why the dynamic_cast is used here? |