Differential D16281

update epub test data and test for comment property
ClosedPublic
Actions

Authored by astippich on Oct 17 2018, 7:30 PM.

Details

Reviewers
bruns
Commits
R286:d97b15679179: update epub test data and test for comment property
Summary

update the test data for epub and test for
the comment property in the epub autotest

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Oct 17 2018, 7:30 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 17 2018, 7:30 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Oct 17 2018, 7:30 PM
astippich added a comment.Oct 17 2018, 7:34 PM

In preparation of D12114, which I plan to commandeer

cfeck added a subscriber: cfeck.EditedOct 17 2018, 10:07 PM

Phabricator says the MIME Type was changed from application/epub+zip to application/zip. Is this a problem in Phabricator or in your file?

bruns added a comment.Oct 17 2018, 11:51 PM
In D16281#344995, @cfeck wrote:

Phabricator says the MIME Type was changed from application/epub+zip to application/zip. Is this a problem in Phabricator or in your file?

The file no longer is spec compliant, as the first file in the zip container has to be the "mimetype" file, see OPF.

bruns requested changes to this revision.Oct 17 2018, 11:51 PM
This revision now requires changes to proceed.Oct 17 2018, 11:51 PM
astippich updated this revision to Diff 43887.Oct 18 2018, 6:00 PM
  • fix test file
bruns accepted this revision.Oct 28 2018, 3:47 PM
This revision is now accepted and ready to land.Oct 28 2018, 3:47 PM
Closed by commit R286:d97b15679179: update epub test data and test for comment property (authored by astippich). · Explain WhyOct 28 2018, 4:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44364

View Options

autotests/epubextractortest.cpp

Loading...
View Options

autotests/samplefiles/test.epub

Loading...