port knetattach from kurl to qurl
ClosedPublic
Actions

Authored by sitter on Oct 17 2018, 2:28 PM.

Details

Reviewers

broulik

Commits

R119:53255b7854eb: port knetattach from kurl to qurl

Summary

kurl is deprecated.

s/kurl/qurl
non-existent functions ported per deprecation recommendation
fileEncoding replaced with url.queryItemValue("charset") which should be the fitting replacement from a quick look at the kurl code

unfortunately there are still more kdelibs4support requirements left it
seems :(

Test Plan

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sitter requested review of this revision.Oct 17 2018, 2:28 PM

This revision is now accepted and ready to land.Oct 17 2018, 2:59 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			knetattach/knetattach.h (5 lines)
M			knetattach/knetattach.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43794	fbcbab8		Oct 17 2018, 2:28 PM	★	★
Diff 2	43797	fbcbab8	R119:53255b7854eb7d58317555f4c5895e88e911995e	Oct 17 2018, 2:28 PM	★	★