Differential D16269

Show correct current download and upload speed
ClosedPublic
Actions

Authored by jgrulich on Oct 17 2018, 8:07 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R116:c5593b02df38: Show correct current download and upload speed
Summary

After recent change to use NM::DeviceStatistics instead of plasma dataengine, this part
of code wasn't changed and instead of showing current download/upload speed, it was
showing total downloaded/uploaded size

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
Plasma/5.14
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3979
Build 3997: arc lint + arc unit
jgrulich created this revision.Oct 17 2018, 8:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 17 2018, 8:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Oct 17 2018, 8:07 AM
broulik accepted this revision.Oct 17 2018, 8:22 AM
This revision is now accepted and ready to land.Oct 17 2018, 8:22 AM
Closed by commit R116:c5593b02df38: Show correct current download and upload speed (authored by jgrulich). · Explain WhyOct 17 2018, 9:52 AM
This revision was automatically updated to reflect the committed changes.
volkov added a subscriber: volkov.Dec 3 2018, 4:24 PM

I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed.
One can see the current speed on the graph.

jgrulich added a comment.Dec 4 2018, 6:23 AM
In D16269#370817, @volkov wrote:

I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed.
One can see the current speed on the graph.

Oh, sorry for that, I most probably didn't notice this change and assumed it's a bug, because I was checking current speed and was wondering why it shows such big numbers. It's hard to say which information is more useful, I would personally leave the current upload/download to be there and put the total download/upload into the details section or under the graph as it used to be with the old networkmanagement applet.

volkov added a comment.Dec 4 2018, 10:06 AM

The problem with this change is that speed is shown in bytes, not in bytes/s.

Revision Contents
Changeset List

Diff 43781

View Options

applet/contents/ui/ConnectionItem.qml

Loading...
View Options

libs/models/networkmodel.cpp

Loading...