Differential D16261

[effects/screenshot] Use override keyword
ClosedPublic
Actions

Authored by zzag on Oct 16 2018, 9:48 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:d014f2ab74df: [effects/screenshot] Use override keyword
Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Oct 16 2018, 9:48 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 16 2018, 9:48 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 16 2018, 9:48 PM
davidedmundson accepted this revision.Oct 16 2018, 11:00 PM
davidedmundson added a subscriber: davidedmundson.

I think there's a clazy script that does this automagically

This revision is now accepted and ready to land.Oct 16 2018, 11:00 PM
zzag added a comment.EditedOct 16 2018, 11:07 PM
In D16261#344448, @davidedmundson wrote:

I think there's a clazy script that does this automagically

FWIW, some time ago, I submitted a patch to use override keyword in effects, MF didn't like that.

Closed by commit R108:d014f2ab74df: [effects/screenshot] Use override keyword (authored by zzag). · Explain WhyOct 16 2018, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/screenshot/screenshot.h (7 lines)

Diff 43770

View Options

effects/screenshot/screenshot.h

Loading...