[Scheduler] Remove extraneous set of content indexing flag
ClosedPublic

Authored by bruns on Oct 16 2018, 5:23 PM.

Details

Summary

The content indexing flag is already set by the BasicIndexingJob::index()
in ModifiedFileIndexer::run() executed previously. Instead of doing
another write transaction just update it when updating the other DBs
in replaceDocument(), like it is already done in addDocument().

Also, the flag was even set when the config only specifies BasicIndexing,
i.e. content indexing was always done.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 16 2018, 5:23 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 16 2018, 5:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 16 2018, 5:23 PM
bruns updated this revision to Diff 43757.Oct 16 2018, 8:54 PM

also write the id in replaceDocument, not only addDocument

bruns edited the summary of this revision. (Show Details)Oct 16 2018, 8:59 PM
ngraham accepted this revision.Oct 17 2018, 1:55 AM
This revision is now accepted and ready to land.Oct 17 2018, 1:55 AM
This revision was automatically updated to reflect the committed changes.