Added content for tool bar embeded in other components and on responsive behavior of the toolbar.
Details
Details
Diff Detail
Diff Detail
- Repository
- R985 KDE Human Interface Guidelines
- Branch
- toolbar
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4690 Build 4708: arc lint + arc unit
Comment Actions
Just a few comments.
Side note: I don't like how we're inconsistent with "tool bar" and "toolbar". I would suggest standardizing on "toolbar".
| source/components/navigation/toolbar.rst | ||
|---|---|---|
| 28 | Captions don't need periods at the end | |
| 75 | Remove "from user" (or replace with "from the user") | |
| 87–88 | Rewrite this as: Do not change the button style from the default, which is is "text beside icons" | |
Comment Actions
- Merge remote-tracking branch 'origin/master' into toolbar
- Renamed tool bar as toolbar. Removed duplicate image in toolbar page.
Comment Actions
Thanks, this is looking great! Just a few more comments below...
| source/components/navigation/toolbar.rst | ||
|---|---|---|
| 24–29 | an other -> another inline mesage it is used -> inline mesage, it is used | |
| 34–36 | "apply" -> "show" or maybe "display" | |
| 46 | Hmm, quite a lot of our apps have toolbar buttons that show drop-down menus. Are we sure this is a problem? | |
| 63 | only, if -> only if | |
| 75 | This one isn't addressed yet. I still see "from user" at the end of the sentence. | |
| 88–90 | which is is -> which is | |