Use correct color and font when exporting to HTML
ClosedPublic

Authored by sandsmark on Oct 15 2018, 4:53 PM.

Details

Summary

Instead of using only the default colors (and white background),
use the correct colors and font from the profile, if available. If
not exporting with a profile, it falls back to the old behavior
(i. e. when copying to clipboard).

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark created this revision.Oct 15 2018, 4:53 PM
Restricted Application added a project: Konsole. · View Herald TranscriptOct 15 2018, 4:53 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
sandsmark requested review of this revision.Oct 15 2018, 4:53 PM

I don't know why your patches rename/move the files - I don't have this issue w/ other people's patches.

rename from src/SessionController.cpp
rename to SessionController.cpp

rename from src/TerminalCharacterDecoder.cpp
rename to TerminalCharacterDecoder.cpp

Indeed, I noticed that too. Very annoying. @sandsmark, could you use arc to submit patches? That would eliminate the problem. Documentation is available at https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

it's probably because phabricator doesn't handle patches generated when I have diff.noprefix=true (which is very convenient when working on stuff), it seems to indiscriminately just strip the first path component. I'll upload a new version when I get home.

sandsmark updated this revision to Diff 44239.Oct 26 2018, 8:00 AM

Added the prefixes to the diff, sorry for the delay.

hindenburg edited the summary of this revision. (Show Details)Oct 27 2018, 6:48 PM
hindenburg accepted this revision.Oct 27 2018, 7:20 PM

Thanks, the output looks great. if you're using arc, try setting your name/address.

This revision is now accepted and ready to land.Oct 27 2018, 7:20 PM
This revision was automatically updated to reflect the committed changes.