Differential D16217

Do not capture 'this' as it is not used
ClosedPublic
Actions

Authored by yurchor on Oct 15 2018, 7:42 AM.

Details

Reviewers
broulik
Group Reviewers
KDE Applications
Commits
R228:8982078a3b07: Do not capture 'this' as it is not used
Summary

Lambda capture is not used below, there is no need to capture it (or it should be used in the 'connect' later). I'm not a lambda-expert. Please advise.

Clang warning:

https://build.kde.org/job/Applications/job/kfind/job/kf5-qt5%20FreeBSDQt5.11/13/warnings12Result/NORMAL/

Test Plan

Everything works so far without this capture.

Diff Detail

Repository
R228 KFind
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor requested review of this revision.Oct 15 2018, 7:42 AM
yurchor created this revision.
broulik accepted this revision.Oct 15 2018, 2:50 PM
This revision is now accepted and ready to land.Oct 15 2018, 2:50 PM
Closed by commit R228:8982078a3b07: Do not capture 'this' as it is not used (authored by yurchor). · Explain WhyOct 15 2018, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kftabdlg.cpp (2 lines)

Diff 43661

View Options

src/kftabdlg.cpp

Loading...