[effects/diminactive] Add option to exclude fullscreen windows from dimming
ClosedPublic

Authored by zzag on Oct 15 2018, 7:34 AM.

Details

Summary

Such an option would be useful for people that are used to watch videos
in the fullscreen mode.

By default, we still dim fullscreen windows because watching videos in
fullscreen mode is not the only one use-case. One could have a text
editor in fullscreen mode on one screen and Konsole on another screen.
In that case, it would be desired to dim the text editor if the latter
is active. Also, because we don't have stats of how the fullscreen mode
is used by KDE Plasma users.

BUG: 399822
FIXED-IN: 5.15.0

Test Plan
  • Unchecked the "Fullscreen windows" checkbox;
  • Opened Konsole;
  • Opened Firefox in the fullscreen mode;
  • Pressed Alt+Tab;
  • (Firefox stayed bright)

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Oct 15 2018, 7:34 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 15 2018, 7:34 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 15 2018, 7:34 AM
davidedmundson accepted this revision.Oct 15 2018, 7:36 AM
This revision is now accepted and ready to land.Oct 15 2018, 7:36 AM
This revision was automatically updated to reflect the committed changes.