[client] Ensure PlasmaWindowManagement updates active window if it goes away
ClosedPublic

Authored by graesslin on May 17 2016, 7:02 AM.

Details

Summary

So far when the active PlasmaWindow got unmapped or destroyed, the
PlasmaWindowManagement didn't update the activeWindow. This means it
could expose a deleted object through it's API which could result in
a crash.

This change addresses the problem by updating the active window when
a window gets unmapped or destroyed.

Test Plan

Tests added which exposed the problem

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3831.May 17 2016, 7:02 AM
graesslin retitled this revision from to [client] Ensure PlasmaWindowManagement updates active window if it goes away.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 17 2016, 7:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.May 17 2016, 9:36 AM
hein edited edge metadata.
This revision is now accepted and ready to land.May 17 2016, 9:36 AM
This revision was automatically updated to reflect the committed changes.