Quick Open: Remove "file:///" prefix from file paths
ClosedPublic

Authored by gregormi on Oct 14 2018, 5:58 PM.

Details

Summary

In the second column, remove all "file:///" prefixes from the file paths.

Screenshot BEFORE:

(Note, that the screenshot was taken at a time where the file paths in the upper section where not bold (before d6e38c0cbd3d6d7f7658862757b8c33db4322d7a). Now, the items in the first and second column are both bold)

AFTER:

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3873
Build 3891: arc lint + arc unit
gregormi created this revision.Oct 14 2018, 5:58 PM
Restricted Application added a project: Kate. · View Herald TranscriptOct 14 2018, 5:58 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Oct 14 2018, 5:58 PM
gregormi retitled this revision from Quick Open: remove file:/// prefix to Quick Open: Remove file:/// prefix.Oct 14 2018, 5:59 PM
gregormi edited the summary of this revision. (Show Details)
gregormi edited the summary of this revision. (Show Details)
gregormi updated this revision to Diff 43616.Oct 14 2018, 7:16 PM
  • tabswitchertest: use QFETCH
gregormi updated this revision to Diff 43617.Oct 14 2018, 7:21 PM
  • Revert unrelated "tabswitchertest: use QFETCH"

@tcanabrava Does this clash with your patch in D15804 ?

broulik added inline comments.
kate/katequickopen.cpp
170 ↗(On Diff #43608)

Prefer toDisplayString() for user-visible places which will strip out the password

gregormi updated this revision to Diff 43642.Oct 15 2018, 10:07 AM
  • use toDisplayString

@tcanabrava Does this clash with your patch in D15804 ?

I think it is better if D15804 goes in first, e.g. alreadySeenFiles is removed by his change. Maybe @tcanabrava can incorporate the prettyDocumentUrl part if that is still necessary.

gregormi updated this revision to Diff 43646.EditedOct 15 2018, 10:51 AM
  • Proposal for column sizing for the case of long file names

This is how it looks like if in the git project are really long filenames:

This is how it looks like after the column sizing proposal:

This, after Ctrl+Alt+O is pressed again after having already entered a filter string:

Do you have to rebase your patch now that the other patch is in?

You have to rebase, and probably fix the conflict because I moved the code
to a real model.

Em qua, 17 de out de 2018 às 13:27, Dominik Haumann <
noreply@phabricator.kde.org> escreveu:

dhaumann added a comment. View Revision
https://phabricator.kde.org/D16204

Do you have to rebase your patch now that the other patch is in?

*REPOSITORY*
R40 Kate

*REVISION DETAIL*
https://phabricator.kde.org/D16204

*To: *gregormi, Kate
*Cc: *broulik, dhaumann, tcanabrava, kwrite-devel, michaelh, ngraham,
demsking, cullmann, sars

kfunk added a subscriber: kfunk.Oct 18 2018, 5:41 AM
kfunk added inline comments.
kate/katequickopen.cpp
166 ↗(On Diff #43608)

Note: Is this any different to url.toDisplayString(QUrl::PreferLocalFile) now?

gregormi updated this revision to Diff 44778.EditedNov 3 2018, 3:47 PM

Rewrite for latest master after https://phabricator.kde.org/D15804 was merged in

gregormi marked 2 inline comments as done.Nov 3 2018, 3:50 PM
gregormi added inline comments.
kate/katequickopen.cpp
166 ↗(On Diff #43608)

Good idea, I used QUrl::PreferLocalFile in the revised code.

gregormi edited the summary of this revision. (Show Details)Nov 3 2018, 3:53 PM
gregormi retitled this revision from Quick Open: Remove file:/// prefix to Quick Open: Remove "file:///" prefix from file paths.
gregormi marked an inline comment as done.

Ready from my side.

Friendly ping. :-)

cullmann accepted this revision.Nov 11 2018, 2:10 PM
cullmann added a subscriber: cullmann.

Upsa, forgot, please push.

This revision is now accepted and ready to land.Nov 11 2018, 2:10 PM
This revision was automatically updated to reflect the committed changes.