Make SerialLayer completely private
ClosedPublic

Authored by rizzitello on Oct 14 2018, 4:34 PM.

Details

Summary

Serial Layer shoudn't be exposed to anything higher then atcore.
Clients need to reconnect their logWidget to Atcore::pushedCommand
Should land before D16181

Diff Detail

Repository
R232 AtCore
Branch
privateSerial
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4091
Build 4109: arc lint + arc unit
rizzitello requested review of this revision.Oct 14 2018, 4:34 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Oct 14 2018, 4:36 PM
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
rizzitello updated this revision to Diff 43595.Oct 14 2018, 4:41 PM
rizzitello edited the summary of this revision. (Show Details)
  • adjust logWidget documentation
laysrodrigues accepted this revision.Oct 15 2018, 10:21 PM
This revision is now accepted and ready to land.Oct 15 2018, 10:21 PM

What is the logic behind this change ?

What is the logic behind this change ?

AtCore Clients shouln't need to talk directly to the serialLayer. AtCore should provide any functions the clients need to manage their stuff and not require them to directly access anything below it .

rizzitello updated this revision to Diff 43971.Oct 20 2018, 2:56 PM
  • Fix base / rebase
rizzitello updated this revision to Diff 44002.Oct 21 2018, 1:10 AM
  • add missing scoped enum
tcanabrava accepted this revision.Oct 21 2018, 4:02 PM
rizzitello closed this revision.Oct 21 2018, 4:26 PM