add a test for tracks with empty artist tag in database
ClosedPublic

Authored by astippich on Oct 14 2018, 8:38 AM.

Details

Summary

adds a test for tracks with empty artist tag in database, currently failing

CCBUG: 389136
CCBUG: 393118
CCBUG: 396607

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Oct 14 2018, 8:38 AM
astippich created this revision.

This is currently not fully working yet. I could verify that the track gets added correctly to the database, and the artist query is correctly skipped. But the track is not fetched from the database with the selectTrackFromIdQuery, and hence the test fails. I'm no expert in SQL, and haven't found a solution for that yet, so any help is appreciated.

astippich updated this revision to Diff 43577.Oct 14 2018, 8:44 AM
  • cleanup
  • cleanup

I am working on a refactor of the database that includes removing the TracksArtists table. That should make it very easy to implement this feature. Could you only add the automatic tests with expected failure and I include this in my patch ?

  • cleanup

I am working on a refactor of the database that includes removing the TracksArtists table. That should make it very easy to implement this feature. Could you only add the automatic tests with expected failure and I include this in my patch ?

Sure. I was also wondering why there was a separate TracksArtists table.

astippich updated this revision to Diff 43817.Oct 17 2018, 6:54 PM
  • only add test for empty artist
astippich retitled this revision from [WIP] allow tracks with empty artist tag in database to add a test for tracks with empty artist tag in database.Oct 17 2018, 6:54 PM
astippich edited the summary of this revision. (Show Details)
mgallien accepted this revision.Oct 23 2018, 3:26 PM

Nice, thanks

This revision is now accepted and ready to land.Oct 23 2018, 3:26 PM

Since this test is currently failing, shall I land it and it will be fixed afterwards?

astippich updated this revision to Diff 44571.Oct 31 2018, 8:27 PM
  • additional fix for the test
This revision was automatically updated to reflect the committed changes.