Prevent QWebEngine from overriding signal handlers
ClosedPublic

Authored by croick on Oct 13 2018, 10:23 PM.

Details

Summary
  • The documentation view may use QWebEngine, which is based on Chromium, which installs its own signals handlers. This breaks the use of KCrash.
  • Overriding the signal handlers can be prevented by setting an environment variable before the use, just like in D16004.
Test Plan
  • open a documentation page in KDevelop
  • kill SIGABRT KDevelop -> DrKonqi shows up

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
croick created this revision.Oct 13 2018, 10:23 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptOct 13 2018, 10:23 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
croick requested review of this revision.Oct 13 2018, 10:23 PM
apol accepted this revision.Oct 14 2018, 10:58 PM
This revision is now accepted and ready to land.Oct 14 2018, 10:58 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a subscriber: kfunk.Oct 15 2018, 10:30 AM

Nice find! Will cherry-pick to 5.3 branch.