Details
- Reviewers
rizzitello tcanabrava
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
How do we send commands now before connected to a firmware? M115 has to be sent before any firmware connection, It works on Grbl because were looking for the name. This does seam like progress in the correct direction we just need to smooth out this important case.
| src/core/ifirmware.cpp | ||
|---|---|---|
| 75 | Can not append to const | |
There is a generic function when a plugin is not loaded.
M115 has to be sent before any firmware connection.
Yes, you can use the default function like I said before.
This only moves the terminator to the plugin side from the seriallayer.
This is not ready to compile yet, some work is still in progress.
Not sure why but with this patch i get lines cut off and split across a few entries. Im not sure if this is related to auto detect failing for me.
[19:03:34:325]< echo:Com
[19:03:34:330]< piled: Sep 19 2018
[19:03:34:330]< echo: Free Memory: 3034 Plann
[19:03:34:333]< erBufferBytes: 1232
[19:03:34:341]< echo:V47 stored settings retrie
[19:03:34:346]< ved (614 bytes; crc 19530)
| src/core/ifirmware.cpp | ||
|---|---|---|
| 75 | This works, a previous diff was failing. | |
| src/plugins/grblplugin.cpp | ||
|---|---|---|
| 57 | Is this code retained somewhere or does the reading behavior change where this is no longer needed to correctly send lines made of a few commands? If not why are we removing it? | |